Demo tinygo CI : experimental net + cpuid builds [WON'T MERGE]#3306
Draft
leongross wants to merge 2 commits intou-root:mainfrom
Draft
Demo tinygo CI : experimental net + cpuid builds [WON'T MERGE]#3306leongross wants to merge 2 commits intou-root:mainfrom
leongross wants to merge 2 commits intou-root:mainfrom
Conversation
51bdbd0 to
7c8900e
Compare
jenstopp
reviewed
Feb 19, 2025
Member
jenstopp
left a comment
There was a problem hiding this comment.
Pls comment on the empty imports of _ "github.com/u-root/cpuid" why it is necessary, that it is temporary and when it can be removed again.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
=======================================
Coverage 58.43% 58.43%
=======================================
Files 612 612
Lines 51680 51680
=======================================
+ Hits 30198 30200 +2
+ Misses 21482 21480 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
769ea1d to
88d629c
Compare
88d629c to
c1179d7
Compare
binjip978
previously approved these changes
Feb 20, 2025
Member
Author
|
@jensdrenhaus should we get this in or is it sufficient to keep this as an open PR for now? |
c1179d7 to
0bc1a35
Compare
Member
|
This PR is just to show how the tinygo CI in u-root would pass when including some non-upstream tinygo changes. |
e9a92f0 to
8c81e1f
Compare
Use https://github.com/leongross/tinygo/tree/threading-netsquash to build all u-root commands with network support. Enable previously failing builds in status quo file. Signed-off-by: leongross <leon.gross@9elements.com>
* update tinygo image version * update github.com/u-root/cpuid package version in go.mod and go.sum * update vendored dependecies Signed-off-by: leongross <leon.gross@9elements.com>
8c81e1f to
f94ec83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test runner to show the buildability of all u-root commands using the experimental
tinygonetwork support.