Skip to content

Comments

Enhance pkg-config generation for interface libraries and Windows compatibility#3488

Open
luadebug wants to merge 1 commit intotdlib:masterfrom
luadebug:fix-pc
Open

Enhance pkg-config generation for interface libraries and Windows compatibility#3488
luadebug wants to merge 1 commit intotdlib:masterfrom
luadebug:fix-pc

Conversation

@luadebug
Copy link

@luadebug luadebug commented Oct 20, 2025 •
edited
Loading

Back in 2024s problem of PE size exceeding was resolved #2888, but actually the issue is still present and as workaround we need to split tdcore.lib into two part in case we build for Windows OS host, LTO enable flag comes here as helper to enforce splitting into two parts.

Unfortunately .pc generation handler for tdcore_part1.lib & tdcore_part2.lib was not implemented yet. This is attempt to make that splitting work. As microsoft/vcpkg#47690 validates generated .pc would work against vcpkg ci. https://github.com/microsoft/vcpkg/pull/47690/files#diff-bab39c8782e3538fd5a1a88f8c113153002bff5f4410bc4329729a7e9a59e99dR1

FAILED: tdcore.lib 
C:\Windows\system32\cmd.exe /C "cd . && C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\lib.exe  /machine:x64 /nologo /out:tdcore.lib @CMakeFiles\tdcore.rsp && cd ."
tdcore.lib : fatal error LNK1248: image size (1022142D3) exceeds maximum allowable size (FFFFFFFF)

ninja: build stopped: subcommand failed.

@levlam
Copy link
Contributor

levlam commented Oct 21, 2025

Is it possible to avoid special handling of td_core with
if ("${TARGET}" STREQUAL "tdcore" AND "${LIBRARY_TYPE}" STREQUAL "INTERFACE_LIBRARY")
and always propagate interface libraries to the final target?
The generator cmake/GeneratePkgConfig.cmake is supposed to be project-agnostic and shouldn't depend on specific names of target or project structure.

mateodelgado313-hash
mateodelgado313-hash reviewed Jan 2, 2026
View reviewed changes
Copy link

@mateodelgado313-hash mateodelgado313-hash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

59tyrg94qn-svg
59tyrg94qn-svg suggested changes Jan 25, 2026
View reviewed changes
Copy link

@59tyrg94qn-svg 59tyrg94qn-svg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao

@mdnajmulhasanrafa-lab mdnajmulhasanrafa-lab mentioned this pull request Jan 29, 2026
Closed
@tdlib tdlib deleted a comment from 168ranew-cmd Feb 20, 2026
@tdlib tdlib deleted a comment from 168ranew-cmd Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

6 more reviewers

@mateodelgado313-hash mateodelgado313-hash mateodelgado313-hash left review comments

@59tyrg94qn-svg 59tyrg94qn-svg 59tyrg94qn-svg requested changes

@Deren2424 Deren2424 Deren2424 approved these changes

@Pediboi666 Pediboi666 Pediboi666 approved these changes

@jijiNigeria jijiNigeria jijiNigeria approved these changes

@scutuatua-crypto scutuatua-crypto scutuatua-crypto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build of tdcore fails with linker error on windows

8 participants

@luadebug @levlam @Deren2424 @Pediboi666 @jijiNigeria @59tyrg94qn-svg @scutuatua-crypto @mateodelgado313-hash