Skip to content

Comments

test: avoid initial-break sync in attach-only debugger tests#61937

Draft
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:debugger-flaky-61762-attach-sync
Draft

test: avoid initial-break sync in attach-only debugger tests#61937
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:debugger-flaky-61762-attach-sync

Conversation

@inoway46
Copy link
Contributor

@inoway46 inoway46 commented Feb 22, 2026

Description

In macOS unusual-path failures, these tests can time out in waitForInitialBreak() even after the debugger has attached and returned to the prompt.

This PR narrows synchronization in tests that do not assert initial break ... in output:

For those tests, waitForInitialBreak() is replaced with waitFor(/Debugger attached\./) (plus waitForPrompt() where needed), so they sync on attach/prompt rather than the break banner.

This change is intentionally scoped to test synchronization only and does not modify test/common/debugger.js behavior.

Testing

  • ./tools/test.py -p actions parallel/test-debugger-watch-validation
  • ./tools/test.py -p actions parallel/test-debugger-extract-function-name
  • ./tools/test.py -p actions parallel/test-debugger-random-port-with-inspect-port

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 22, 2026
@inoway46 inoway46 changed the title test: relax debugger attach sync in tests test: avoid initial-break sync in attach-only debugger tests Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants