test: avoid initial-break sync in attach-only debugger tests#61937
Draft
inoway46 wants to merge 1 commit intonodejs:mainfrom
Draft
test: avoid initial-break sync in attach-only debugger tests#61937inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In macOS unusual-path failures, these tests can time out in
waitForInitialBreak()even after the debugger has attached and returned to the prompt.This PR narrows synchronization in tests that do not assert initial
break ... inoutput:test/parallel/test-debugger-watch-validation.jstest/parallel/test-debugger-extract-function-name.mjstest/parallel/test-debugger-random-port-with-inspect-port.jsFor those tests,
waitForInitialBreak()is replaced withwaitFor(/Debugger attached\./)(pluswaitForPrompt()where needed), so they sync on attach/prompt rather than the break banner.This change is intentionally scoped to test synchronization only and does not modify
test/common/debugger.jsbehavior.Testing
./tools/test.py -p actions parallel/test-debugger-watch-validation./tools/test.py -p actions parallel/test-debugger-extract-function-name./tools/test.py -p actions parallel/test-debugger-random-port-with-inspect-portRefs: #61762