Add optional branch name regexp check#34
Merged
seqizz merged 1 commit intoinnogames:masterfrom Jul 24, 2023
Merged
Conversation
kofrezo
approved these changes
Jul 17, 2023
Contributor
kofrezo
left a comment
There was a problem hiding this comment.
The preparation of the configuration files is a bit black magic to me so I may have overseen something but overall it looks good to me.
See comments for minor improvements you could do (no blockers tough).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not too happy code-wise since I had to duplicate/modify some stuff, but as far as I can test this one works.
The check is optional like others, enabled when
.igcommit-branch-name.conffile is found on the repository root.