Skip to content

Comments

Prepare version 3.1#20

Merged
kofrezo merged 13 commits intoinnogames:masterfrom
hasegeli:master
Jan 20, 2021
Merged

Prepare version 3.1#20
kofrezo merged 13 commits intoinnogames:masterfrom
hasegeli:master

Conversation

@hasegeli
Copy link
Contributor

This includes fixes and improvements of a bunch of minor things noticed over the last months.

@kofrezo kofrezo requested review from Woellchen and kofrezo November 25, 2019 10:28
@kofrezo
Copy link
Contributor

kofrezo commented Dec 15, 2020

@hasegeli I resolved the conflicts necessary to merge it but there still some discussions open. Are you still up for resolving those and merging the changes ?

@hasegeli
Copy link
Contributor Author

@kofrezo, @Woellchen: I like the templates/ idea. How are we gonna resolve this?

@kofrezo
Copy link
Contributor

kofrezo commented Jan 18, 2021

@kofrezo, @Woellchen: I like the templates/ idea. How are we gonna resolve this?

@Woellchen resolved that part of the discussion any further items to discuss ?

@hasegeli
Copy link
Contributor Author

No. Let me rebase this as version 3.1.

@hasegeli hasegeli changed the title Prepare version 2.6 Prepare version 3.1 Jan 18, 2021
@hasegeli
Copy link
Contributor Author

Done. All of the discussions are incorporated.

@hasegeli hasegeli requested a review from Woellchen January 20, 2021 08:01
@kofrezo kofrezo merged commit 7aa7178 into innogames:master Jan 20, 2021
@hasegeli
Copy link
Contributor Author

hasegeli commented Jan 21, 2021

Thanks for merging.

Could you please push tags for the previous and this version so they appear on the releases:

git tag v3.0 a9457d0
git tag v3.1 7aa7178
git push --tags

Also it would be nice to push them to PyPi:

https://pypi.org/project/igcommit/

I granted access to your user.

@Woellchen
Copy link
Member

i pushed the tags already, would wait for @kofrezo though for pypi

@hasegeli
Copy link
Contributor Author

Let me add you too. What's your username?

@kofrezo
Copy link
Contributor

kofrezo commented Jan 25, 2021

I will push it this week I did not make it last week due to a training.

@kofrezo
Copy link
Contributor

kofrezo commented Jan 25, 2021

3.1 has been released: https://pypi.org/project/igcommit/#history

@hasegeli
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants