fix(client): update text container for fsd lessons#65889
fix(client): update text container for fsd lessons#65889AdityaSingh-18 wants to merge 3 commits intofreeCodeCamp:mainfrom
Conversation
moT01
left a comment
There was a problem hiding this comment.
Left one comment about the code - maybe fine to just leave it. Regarding the UI - it's not bad...
image
The text is more readable, but the editor feels a little wide. I shrunk the editor and added some margin above and below to check it out (text is the same width):
image
Looks a bit better in my opinion. For the most part, I think that's enough room in the editor to show the code and preview. There may be a few spots where it feels a bit crowded in the editor - couldn't actually find any. I think I would do something like that, what do you think @AdityaSingh-18?
| if ( | ||
| nodule.type === 'interactiveEditor' && | ||
| showInteractiveEditor | ||
| ) { |
There was a problem hiding this comment.
Feels like there's some extra logic happening here. We have pretty much the same check in the renderNodule function.
There was a problem hiding this comment.
Correct me if I’m mistaken, but although the checks look similar, they serve different purposes. The renderNodule function is used for rendering the data, while the map() function is for layout wrapper.
So currently, when nodule.type is interactiveEditor and the editor is ON, it is rendered directly at full width. For all other nodules or when the editor is OFF, the <Col /> wrapper is applied to display data like in non-interactiveEditor lectures.
|
Yes, I agree with slightly shrinking the editor. After adjusting the text width, the editor does feel a bit too wide in comparison. Also I saw a PR on adding the navbar on the review pages. I currently don't have much idea about how it will works, but I think it would be helpful otherwise the navbar might overlap or cut the editor content. |
|
@moT01 I have shrunk the editor and added margin. Please let me know if any changes are needed. Image
(Also should I remove those comments in code?) |
Checklist:
mainbranch of freeCodeCamp.Closes #63699
This PR is to update the text container for fsd lessons to make the lesson content width consistent and less wide, while keeping the interactive editor width unchanged.
Changes Made: