Skip to content

Comments

refactor(forms): clean up#67182

Open
leonsenft wants to merge 1 commit intoangular:mainfrom
leonsenft:sf-cleanup
Open

refactor(forms): clean up#67182
leonsenft wants to merge 1 commit intoangular:mainfrom
leonsenft:sf-cleanup

Conversation

@leonsenft
Copy link
Contributor

@leonsenft leonsenft commented Feb 20, 2026

  • Remove unused TValue type parameter from FormUiControl
  • Remove unused imports
  • Remove unnecessary cast

@leonsenft
refactor(forms): clean up
ed78b87 
* Remove unused `TValue` type parameter from `FormUiControl`
* Remove unused imports
* Remove unnecessary cast
@leonsenft leonsenft requested a review from kirjs February 20, 2026 21:22
@leonsenft leonsenft added area: forms target: minor This PR is targeted for the next minor release forms: signals labels Feb 20, 2026
@ngbot ngbot bot modified the milestone: Backlog Feb 20, 2026
@leonsenft leonsenft marked this pull request as ready for review February 20, 2026 21:22
@pullapprove pullapprove bot requested a review from mmalerba February 20, 2026 21:23
@leonsenft leonsenft mentioned this pull request Feb 20, 2026
Draft
@pullapprove pullapprove bot requested a review from kirjs February 20, 2026 23:06
kirjs
kirjs reviewed Feb 20, 2026
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from kirjs February 20, 2026 23:07
@leonsenft leonsenft added the action: merge The PR is ready for merge by the caretaker label Feb 20, 2026
kirjs
kirjs approved these changes Feb 20, 2026
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@leonsenft leonsenft removed the request for review from mmalerba February 20, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirjs kirjs kirjs approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms forms: signals target: minor This PR is targeted for the next minor release

Projects

Experimental Signal Forms
Status: No status

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@leonsenft @kirjs @mmalerba