Fix Restart-Computer to work on localhost when WinRM is not present#9160
Merged
adityapatwardhan merged 6 commits intoPowerShell:masterfrom Mar 19, 2019
Merged
Conversation
…n WinRM is not present
Member
Author
|
The change has been manually tested on winPE arm64 machine. |
SteveL-MSFT
requested changes
Mar 19, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@SteveL-MSFT Please re-review, comments addressed. |
Restart-Computer and Rename-Computer to work on localhost when WinRM is not presentRestart-Computer to work on localhost when WinRM is not present
iSazonov
reviewed
Mar 19, 2019
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
How would we test this in CIs?
src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: adityapatwardhan <adityap@microsoft.com>
SteveL-MSFT
requested changes
Mar 19, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Mar 19, 2019
iSazonov
approved these changes
Mar 19, 2019
Member
Author
|
@iSazonov - We cannot test this in CI. This specifically repro on special hardware which is not available in CI system. I have tested it manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8197
PR Summary
PowerShell core uses WSMan transport for all operation. When winRM is not present creating a session fails. The PR uses the default transport when the target computer is localhost. We get the instance on
Win32_ComputerSystemand then call the instance method on it to restart the computer.The PR also fixes
Rename-Computersimilarly.PR Context
On winPE arm64, winRM is not present and hence
Restart-Computerfails.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests