Skip to content

Comments

Disable Homebrew analytics in macOS VSTS builds#9130

Merged
TravisEz13 merged 6 commits intoPowerShell:masterfrom
RDIL:patch-3
Mar 16, 2019
Merged

Disable Homebrew analytics in macOS VSTS builds#9130
TravisEz13 merged 6 commits intoPowerShell:masterfrom
RDIL:patch-3

Conversation

@RDIL
Copy link
Contributor

@RDIL RDIL commented Mar 13, 2019

PR Summary

Since these are just test installs they should not count towards the totals in the formulae analytic center.

PR Context

  • this will save about 15-20 seconds but all time counts

By default this is on but it shouldn't be

PR Checklist

@TravisEz13
Copy link
Member

TravisEz13 commented Mar 13, 2019

Can you make a similar change in the following location:

https://github.com/PowerShell/PowerShell/blob/master/tools/releaseBuild/azureDevOps/templates/mac.yml

You'll have to add the variables statement between lines 5 and 9

@RDIL
Copy link
Contributor Author

RDIL commented Mar 13, 2019

On it

@RDIL
Copy link
Contributor Author

RDIL commented Mar 13, 2019

@TravisEz13 fixed

RDIL added 2 commits March 14, 2019 10:38
codefactor is spamming my email and so this empty push is to disable it
@RDIL
Copy link
Contributor Author

RDIL commented Mar 15, 2019

@TravisEz13 @iSazonov please re review

@TravisEz13 TravisEz13 added this to the 6.2.0-GA-Consider milestone Mar 16, 2019
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 16, 2019
@TravisEz13 TravisEz13 merged commit eac3101 into PowerShell:master Mar 16, 2019
@RDIL RDIL deleted the patch-3 branch March 16, 2019 18:58
@TravisEz13 TravisEz13 modified the milestones: 6.2.0-GA-Consider, 6.2.0 Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants