Publish test package on release builds#9063
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Mar 6, 2019
Merged
Publish test package on release builds#9063adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
RDIL
reviewed
Mar 5, 2019
| displayName: Build test package | ||
|
|
||
| - pwsh: | | ||
| if (-not (Test-Path $(System.ArtifactsDirectory)/TestPackage.zip)) |
Contributor
There was a problem hiding this comment.
Suggestion: Maybe some of this PowerShell block should be moved into a new function in ./tools/ci.psm1
Member
Author
There was a problem hiding this comment.
This is not for CI so, this does not belong in ci.psm1
Member
There was a problem hiding this comment.
It would be good if in the future we had a similar module for release builds.
TravisEz13
approved these changes
Mar 5, 2019
TravisEz13
pushed a commit
that referenced
this pull request
Mar 13, 2019
# Conflicts: # tools/releaseBuild/azureDevOps/diagram.puml # tools/releaseBuild/azureDevOps/diagram.svg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The PR publishes the tests and other artifacts required for testing as artifacts.
There are two artifacts created, one for Linux and one for Windows.
macOS is not done currently, as we can rely on CI for testing on macOS.
Also updated the UML diagram.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests