Skip to content

Comments

Fix MSI Upgrade failure for preview builds#9013

Merged
TravisEz13 merged 8 commits intoPowerShell:masterfrom
TravisEz13:Fix_MSI_issue
Feb 28, 2019
Merged

Fix MSI Upgrade failure for preview builds#9013
TravisEz13 merged 8 commits intoPowerShell:masterfrom
TravisEz13:Fix_MSI_issue

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Feb 28, 2019 •
edited
Loading

PR Summary

  • Fix MSI Upgrade failure for preview builds
    • Changing the identifiers every build should resolve this issue.
    • Also, tell MSI to reinstall components if the version changed in any way.

PR Context

Hopefully really fix #8289 this time

Testing of RC.1 found we still got this error when upgrading from preview.4

MSI (s) (4C:A8) [10:18:32:354]: Disallowing installation of component: {A60E946A-2C86-4104-B883-D4B17B50B5B0} since the same component with higher versioned keyfile exists
MSI (s) (4C:A8) [10:18:32:487]: Disallowing installation of component: {7E693303-C675-4985-A1F0-84688E685656} since the same component with higher versioned keyfile exists
MSI (s) (4C:A8) [10:18:32:783]: Disallowing installation of component: {1CCDF75D-482A-4B20-B3D1-2934D374B96B} since the same component with higher versioned keyfile exists
MSI (s) (4C:A8) [10:18:32:787]: Disallowing installation of component: {267520C6-CD61-4FF4-9CA4-83400EAAC3E9} since the same component with higher versioned keyfile exists
MSI (s) (4C:A8) [10:18:32:825]: Disallowing installation of component: {F7B290E8-4DDD-4C20-B3F8-5DD38608DFEF} since the same component with higher versioned keyfile exists

With the component also being deleted.

The previous fix didn't change the GUID identifier which triggers the deletion.

PR Checklist

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Feb 28, 2019

@TravisEz13 Could you add more information in the description

iSazonov
iSazonov reviewed Feb 28, 2019
View reviewed changes
tools/packaging/packaging.psm1
# We only need to use $FilesWxsPath for release we want to be able to Path
# and two releases shouldn't have the same identifiers,
# so we use the generated one for preview
$FilesWxsPath = $wixFragmentPath
Copy link
Collaborator

@iSazonov iSazonov Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break the update one preview to next preview?

Copy link
Member Author

@TravisEz13 TravisEz13 Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is the code we were using before I added the code to allow for patching.

@TravisEz13 TravisEz13 changed the title Fix msi issue Fix MSI Upgrade failure for preview builds Feb 28, 2019
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 28, 2019
@TravisEz13 TravisEz13 merged commit d7dd4b5 into PowerShell:master Feb 28, 2019
@TravisEz13 TravisEz13 deleted the Fix_MSI_issue branch February 28, 2019 22:07
@TravisEz13
Copy link
Member Author

TravisEz13 commented Feb 28, 2019

Merged this so we can cherry-pick into the the RC.1 release

TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Mar 5, 2019
@TravisEz13
Fix MSI Upgrade failure for preview builds (PowerShell#9013)
2a2ffd5
@daxian-dbw daxian-dbw modified the milestone: 6.2.0 Mar 11, 2019
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@TravisEz13 @adityapatwardhan
Merged PR 8385: Fix MSI WIX generation (PowerShell#9013)
a6af42c 
Fix MSI WIX generation (PowerShell#9013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PowerShell-6.2.0-preview.2-win-x64 error on startup (also occurs on upgrade to preview.3)

4 participants

@TravisEz13 @adityapatwardhan @iSazonov @daxian-dbw