Remove some of the last AppVeyor references#8867
Merged
TravisEz13 merged 20 commits intoPowerShell:masterfrom Feb 19, 2019
RDIL:patch-1
Merged
Remove some of the last AppVeyor references#8867TravisEz13 merged 20 commits intoPowerShell:masterfrom RDIL:patch-1
TravisEz13 merged 20 commits intoPowerShell:masterfrom
RDIL:patch-1
Conversation
TravisEz13
reviewed
Feb 12, 2019
TravisEz13
reviewed
Feb 12, 2019
TravisEz13
reviewed
Feb 12, 2019
iSazonov
approved these changes
Feb 12, 2019
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
LGTM but we need CodeCov.
ThreeFive-O
reviewed
Feb 12, 2019
ThreeFive-O
reviewed
Feb 12, 2019
ThreeFive-O
reviewed
Feb 12, 2019
ThreeFive-O
reviewed
Feb 12, 2019
test/powershell/engine/ExperimentalFeature/ExperimentalFeature.Basic.Tests.ps1
Show resolved
Hide resolved
TravisEz13
approved these changes
Feb 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This removes some of the last mentions of the name. Don't change the title, we don't want the word to appear in the CLs
Also problem: the last references are in the changelogs but I don't want to modify them without committee approval.
PR Context
it was removed, #8686
other stuff
codefactor is failing because of issues I didn't make so yeah please don't blame meeee
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests