Move Final artifacts from universal build to finalResults folder#8806
Merged
TravisEz13 merged 13 commits intoPowerShell:masterfrom Feb 1, 2019
Merged
Move Final artifacts from universal build to finalResults folder#8806TravisEz13 merged 13 commits intoPowerShell:masterfrom
finalResults folder#8806TravisEz13 merged 13 commits intoPowerShell:masterfrom
Conversation
adityapatwardhan
approved these changes
Feb 1, 2019
Member
adityapatwardhan
left a comment
There was a problem hiding this comment.
Both comments are non-blocking.
| parameters: | ||
| artifactPath: | ||
| artifactFilter: '*' | ||
| condition: succeeded() |
Member
There was a problem hiding this comment.
Do we want succeeded() or failOrSucceeded()? Maybe we should be able to upload whatever artifacts were built.
Member
Author
There was a problem hiding this comment.
We should think about retry scenarios. We don't want to leave this folder potentially polluted.
| parameters: | ||
| artifactPath: | ||
| artifactFilter: '*' | ||
| condition: succeeded() |
Member
There was a problem hiding this comment.
Maybe add a parameter for container name to make this task more general and default it to finalResults
Member
Author
There was a problem hiding this comment.
This change can be made later.
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
May 14, 2019
…owerShell#8806) ## PR Summary Move Final artifacts from universal build to `finalResults` folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Move Final artifacts from universal build to
finalResultsfolderPR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests