Skip to content

Comments

Simplify the declaration of new experimental features#8726

Merged
anmenaga merged 3 commits intoPowerShell:masterfrom
daxian-dbw:exp
Jan 25, 2019
Merged

Simplify the declaration of new experimental features#8726
anmenaga merged 3 commits intoPowerShell:masterfrom
daxian-dbw:exp

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jan 23, 2019 •
edited
Loading

PR Summary

Add a new private constructor to bake in the source and isEnabled parameters for declaring a new engine experimental feature.

PR Context

PR Checklist

@daxian-dbw daxian-dbw requested a review from BrucePay as a code owner January 23, 2019 22:02
@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CL-Engine Indicates that a PR should be marked as an engine change in the Change Log and removed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Jan 23, 2019
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jan 23, 2019

@daxian-dbw Please resolve CodeFactor issues.

@anmenaga anmenaga merged commit c35fd70 into PowerShell:master Jan 25, 2019
@daxian-dbw daxian-dbw deleted the exp branch January 26, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@BrucePay BrucePay Awaiting requested review from BrucePay

Assignees

@anmenaga anmenaga

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daxian-dbw @adityapatwardhan @SteveL-MSFT @anmenaga