Generate and deploy reference assembly for Microsoft.PowerShell.Commands.Utility.dll#8716
Merged
TravisEz13 merged 3 commits intoPowerShell:masterfrom Jan 23, 2019
Merged
Conversation
PaulHigin
previously requested changes
Jan 23, 2019
tools/packaging/packaging.psm1
Outdated
|
|
||
| $projectFolder = New-Item -Path "$genAPIFolder/$assemblyName" -ItemType Directory -Force | ||
| $generatedSource = Join-Path $projectFolder "$assemblyName.cs" | ||
| $filteredSource = Join-Path $projectFolder "${assembly}_Filtered.cs" |
Contributor
There was a problem hiding this comment.
"${assemblyName}_Filtered.cs" ?
Member
Author
There was a problem hiding this comment.
Good catch! The filteredSource file is a temporary file and is renamed to $generatedSource after use, that's why I didn't catch it when verifying the changes.
adityapatwardhan
requested changes
Jan 23, 2019
| <LangVersion>Latest</LangVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Management.Infrastructure" Version="1.0.0-alpha08" /> |
Member
There was a problem hiding this comment.
Please change version to 1.0.0. https://www.nuget.org/packages/Microsoft.Management.Infrastructure/1.0.0
TravisEz13
requested changes
Jan 23, 2019
adityapatwardhan
approved these changes
Jan 23, 2019
Member
|
@TravisEz13 @PaulHigin Please have another look. |
TravisEz13
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update
New-ReferenceAssemblyandNew-UnifiedNugetPackageto generate reference assembly forMicrosoft.PowerShell.Commands.Utility.dlland properly deploy it forMicrosoft.PowerShell.Commands.UtilityNuGet package andMicrosoft.PowerShell.SDKNuGet package.An incremental step to fix, eventually, #8121
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests