Fix expect 100-continue Issue with Web Cmdlets#8679
Merged
iSazonov merged 3 commits intoPowerShell:masterfrom Jan 19, 2019
Merged
Fix expect 100-continue Issue with Web Cmdlets#8679iSazonov merged 3 commits intoPowerShell:masterfrom
iSazonov merged 3 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Jan 18, 2019
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
If the change can break some scripts we could mark this with Breaking-Change label.
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@iSazonov It's not a breaking change. In previous versions of .NET Core it would have been as some linux distros were sending the header by default due to curl. That is no longer the case with the new HttpClient stack. By default this header is not sent, but we were (before this PR) forcibly removing it if it was present which means users were not even able to send it if they chose. |
Collaborator
|
@markekraus Thanks! If we don't break any scripts the breaking-change label is not needed. |
iSazonov
approved these changes
Jan 18, 2019
SteveL-MSFT
approved these changes
Jan 18, 2019
adityapatwardhan
approved these changes
Jan 18, 2019
Collaborator
|
@markekraus Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #7199
Web Cmdlets will no longer forcibly remove
Expect: 100-continuefrom web requests.This was a legacy setting that needed to be there because of platform differences that have since been resolved in CoreFX.
PR Context
#7199
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests