Conversation
|
none of the CI systems, commonly available, I'm aware of are smart enough to block PRs that both change the tests and what they tests. It's a hard problem and in most cases you wouldn't want to. |
|
Yup, working on it. |
|
👍 |
|
Just a suggestion: I would have it log if the file has no links so it doesn't look like the file was skipped over or something like that. |
|
I'll add a case like that which is logged when no results are returned. |
There was a problem hiding this comment.
You might consider using ThreadJobs (https://www.powershellgallery.com/packages/ThreadJob/1.1.2) since they are lighter weight.
There was a problem hiding this comment.
This can be done later. The bigger work is even installing the module in a way that it's usable for both devs and CI
adityapatwardhan
left a comment
There was a problem hiding this comment.
Approved with one non-blocking comment.
There was a problem hiding this comment.
Maybe use Get-Job | Remove-Job -Force
|
@TravisEz13 Please have a look at the static analysis failures. |
There was a problem hiding this comment.
What was I thinking when I wrote the OR ELSE... part haha
It will only break tests (not end the world)
e0aaab8 to
295f846
Compare
|
@RDIL Thanks for your help. Would you mind updating the contribution guide with the details that you should run |
|
Sure, bit busy right now but I can in 10-30 mins |
|
No rush at all. Sorry for stomping on your other PR. I wanted to rush this in and make sure we eliminate all the broken links we can. |
PR Summary
Fix broken URL
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests