Skip to content

Comments

Change Clear-Host back to using $RAWUI and clear to work over remoting#8609

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:clear-host-fix
Jan 10, 2019
Merged

Change Clear-Host back to using $RAWUI and clear to work over remoting#8609
daxian-dbw merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:clear-host-fix

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jan 9, 2019 •
edited
Loading

PR Summary

Based on feedback from @BrucePay [Console]::Clear() only works locally and need to revert to using $RAWUI to clear the screen on Windows and clear command to clear on non-Windows so it works over remoting

This reverts part of the change in #8603

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from BrucePay January 9, 2019 00:07
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 9, 2019

Maybe simply fallback to RawUI:

try {
    [Console]::Clear
} catch {
    # Use RawUI
}

@SteveL-MSFT SteveL-MSFT mentioned this pull request Jan 9, 2019
Closed
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jan 9, 2019

@iSazonov there's interest to convert this to a C# cmdlet and extend it, so let's defer any enhancements to that effort

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 10, 2019

convert this to a C# cmdlet

@SteveL-MSFT Could you please open new Issue for this work? It seems this will be a breaking change and we will need PowerShell Committee approve.

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 10, 2019
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jan 10, 2019

@iSazonov it's implicitly part of #8606 since the way Clear-Host is currently implemented it's impossible to extend

@daxian-dbw daxian-dbw merged commit 66c72c4 into PowerShell:master Jan 10, 2019
@SteveL-MSFT SteveL-MSFT deleted the clear-host-fix branch January 10, 2019 18:44
@HumanEquivalentUnit HumanEquivalentUnit mentioned this pull request Jul 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@BrucePay BrucePay Awaiting requested review from BrucePay

Assignees

@daxian-dbw daxian-dbw

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SteveL-MSFT @iSazonov @daxian-dbw