Improve Start-Sleep cmdlet to accept fractional seconds#8537
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Jan 14, 2019
Merged
Improve Start-Sleep cmdlet to accept fractional seconds#8537adityapatwardhan merged 3 commits intoPowerShell:masterfrom
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
- "Seconds" parameter of Start-Sleep function is now interpreted as double. This removes the rounding error when the parameter with fractions is converted to milliseconds. - ValidateRangeAttribute parameters converted to double to remove error when Seconds parameter is now of double type.
|
|
Member
|
@Prototyyppi Thanks for your first time contribution! I've modified your description to include the issue being fixed so that it closes automatically when this PR is merged. Since cmdlets are also public C# apis, @PowerShell/powershell-committee needs to review this before we can merge. Because of the holidays in the US, the PS-Committee won't meet again til after the new year. |
iSazonov
reviewed
Dec 25, 2018
test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1
Outdated
Show resolved
Hide resolved
Collaborator
|
I updated the PR header. |
iSazonov
reviewed
Dec 25, 2018
test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Dec 25, 2018
Collaborator
|
@Prototyyppi Thanks for your contribution! Please wait PowerShell Committee approval for the public API change. |
Member
|
@PowerShell/powershell-committee reviewed this, cmdlets are not intended to be public APIs, so no concern with taking this change |
PaulHigin
approved these changes
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
double. This removes the rounding error when the parameter with
fractions is converted to milliseconds.
when Seconds parameter is now of double type.
Fix #8477
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests