Enable install-powershell.ps1 to use MSI#8418
Merged
TravisEz13 merged 4 commits intoPowerShell:masterfrom Dec 11, 2018
Merged
Conversation
PaulHigin
approved these changes
Dec 7, 2018
vexx32
reviewed
Dec 7, 2018
adityapatwardhan
requested changes
Dec 7, 2018
adityapatwardhan
approved these changes
Dec 7, 2018
TravisEz13
requested changes
Dec 11, 2018
TravisEz13
approved these changes
Dec 11, 2018
Member
|
Consider adding a test to https://github.com/PowerShell/PowerShell/blob/master/.vsts-ci/install-ps.yml in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Enable
install-powershell.ps1to install the MSI and not just the zip on Windows. Also fixed it so it works from Windows PowerShell.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests