Enable experimental feature to support tab completion on abbreviated cmdlets#8109
Merged
daxian-dbw merged 7 commits intoPowerShell:masterfrom Jan 11, 2019
Merged
Conversation
c5c5351 to
8e113da
Compare
de630aa to
b95ae6d
Compare
|
This needs another |
b95ae6d to
d7721be
Compare
|
@daxian-dbw @BrucePay This PR needs your review. |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
d7721be to
af7ea4e
Compare
JamesWTruher
approved these changes
Jan 7, 2019
Collaborator
JamesWTruher
left a comment
There was a problem hiding this comment.
there's nothing in my comments which are blocking, but I am worried about the case where we have an error (CompletionCompleters, line 193)
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1
Outdated
Show resolved
Hide resolved
daxian-dbw
reviewed
Jan 8, 2019
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
24c1d29 to
f130bd9
Compare
daxian-dbw
reviewed
Jan 10, 2019
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
68d927c to
0893d7c
Compare
daxian-dbw
reviewed
Jan 10, 2019
daxian-dbw
reviewed
Jan 10, 2019
248961b to
9138e21
Compare
Member
|
@SteveL-MSFT There is one comment pending #8109 (comment), can you please respond to it? |
fixed code to support returning multiple results and not just first one added test for automoduleloading which also covers multiple results from different modules
9138e21 to
dc7739e
Compare
Collaborator
|
@daxian-dbw Do we add experimental features to Change log? Do we need set |
This was referenced Jan 28, 2019
10 tasks
TravisEz13
pushed a commit
that referenced
this pull request
Apr 18, 2019
Re-add wildcard when searching AST + Missed test case. ## PR Context In #8109, we removed the line that added a wildcard to the end of the command that was used to match commands in the script AST. This readds that line closer to where it is used.
TravisEz13
pushed a commit
that referenced
this pull request
May 13, 2019
Re-add wildcard when searching AST + Missed test case. ## PR Context In #8109, we removed the line that added a wildcard to the end of the command that was used to match commands in the script AST. This readds that line closer to where it is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
While watching some demos at PSConfAsia, it's obvious that cmdlet nouns have gotten descriptive and wordy (Azure and AWS are good examples). This
experimentalfeature enables tab-completion of abbreviated cmdlets and functions:Note that this only works for tab completion (interactive use), so
i-psdfis still an invalid cmdlet name in scripts.The matching is entirely based on the capital letters of the verb and noun. To test this, create test.json:
{ "ExperimentalFeatures": [ "PSUseAbbreviationExpansion" ] }And run:
Associated RFC
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests