Skip to content

Comments

Allow .exe files to be used as binary modules#7281

Merged
TravisEz13 merged 6 commits intoPowerShell:masterfrom
BrucePay:brucepay_ImportExe
Feb 7, 2019
Merged

Allow .exe files to be used as binary modules#7281
TravisEz13 merged 6 commits intoPowerShell:masterfrom
BrucePay:brucepay_ImportExe

Conversation

@BrucePay
Copy link
Collaborator

@BrucePay BrucePay commented Jul 12, 2018 •
edited by TravisEz13
Loading

PR Summary

Fix for #6741 Allow .exe files to be used as binary modules. Basically anywhere a .dll could be used with modules, you can now use a .exe file. Also did a little clean up, replacing constant strings with the StringLiteral values instead.

PR Checklist

@BrucePay BrucePay requested a review from daxian-dbw as a code owner July 12, 2018 21:25
iSazonov
iSazonov reviewed Jul 13, 2018
View reviewed changes
iSazonov
iSazonov approved these changes Jul 16, 2018
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With two minor comments.

@TravisEz13 TravisEz13 changed the title Fix for #6741 Allow .exe files to be used as binary modules Allow .exe files to be used as binary modules Jul 18, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Jul 18, 2018 •
edited
Loading

Per the contribution guidelines, the issues number you are fixing should not be in the PR Title, only the description. Including it causes us to have to edit it out later when authoring the changelog.

anmenaga
anmenaga approved these changes Jul 27, 2018
View reviewed changes
Copy link

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SteveL-MSFT
SteveL-MSFT requested changes Jul 27, 2018
View reviewed changes
@stale
Copy link

stale bot commented Aug 26, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Aug 26, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Aug 27, 2018

Up.

@stale stale bot removed the Stale label Aug 27, 2018
@anmenaga
Copy link

anmenaga commented Sep 18, 2018

@BrucePay can you please answer Steve's questions? Thanks.

@stale
Copy link

stale bot commented Oct 18, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Oct 18, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 19, 2018 •
edited
Loading

Up. Need rebase.

@stale stale bot removed the Stale label Oct 19, 2018
@anmenaga
Copy link

anmenaga commented Oct 29, 2018

@BrucePay friendly ping.

1 similar comment
@anmenaga
Copy link

anmenaga commented Nov 28, 2018

@BrucePay friendly ping.

@stale
Copy link

stale bot commented Dec 28, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Dec 28, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 6, 2019

@BrucePay @SteveL-MSFT Do we still want to have this?

@stale stale bot removed the Stale label Jan 6, 2019
@stale
Copy link

stale bot commented Feb 5, 2019

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Feb 5, 2019
@TravisEz13
Copy link
Member

TravisEz13 commented Feb 5, 2019

@SteveL-MSFT The build failed

@TravisEz13 TravisEz13 added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log and removed Stale labels Feb 5, 2019
@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Feb 5, 2019

The remaining CodeFactor issues are not related to changes in this PR

@iSazonov
Copy link
Collaborator

iSazonov commented Feb 6, 2019

@SteveL-MSFT CI-Windows stll fail :-(

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Feb 6, 2019

@iSazonov the test failure is unrelated to this change but something we've been seeing for Enter-PSHostProcess. We should mark that test as pending in a separate PR to understand why it's inconsistent.

@TravisEz13 TravisEz13 merged commit 6bc6257 into PowerShell:master Feb 7, 2019
@iSazonov iSazonov mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+2 more reviewers

@rjmholt rjmholt rjmholt approved these changes

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BrucePay @TravisEz13 @iSazonov @anmenaga @SteveL-MSFT @rjmholt