Skip to content

Comments

#4750 Fix Get-Date -UFormat %u behavior#14549

Merged
iSazonov merged 4 commits intoPowerShell:masterfrom
brianary:UFormat_u
Feb 4, 2021
Merged

#4750 Fix Get-Date -UFormat %u behavior#14549
iSazonov merged 4 commits intoPowerShell:masterfrom
brianary:UFormat_u

Conversation

@brianary
Copy link
Contributor

@brianary brianary commented Jan 5, 2021 •
edited by iSazonov
Loading

PR Summary

Corrects the behavior of %u in Get-Date -UFormat to match ISO 8601.

PR Context

This is to fix one of the format issues in #4750.

PR Checklist

@ghost ghost assigned rjmholt Jan 5, 2021
@ghost
Copy link

ghost commented Jan 5, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@brianary
Copy link
Contributor Author

brianary commented Jan 6, 2021

I can't really access the details, but the test failures appear to be unrelated.

@iSazonov iSazonov added Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Documentation Needed in this repo Documentation is needed in this repo labels Jan 6, 2021
iSazonov
iSazonov reviewed Jan 6, 2021
View reviewed changes
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Date.Tests.ps1 Outdated
Comment on lines +100 to +105
Copy link
Collaborator

@iSazonov iSazonov Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify how you select the test values (whole list)?

Copy link
Contributor Author

@brianary brianary Jan 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used the values from the previous test for %V, which is related, then added a couple recent dates that had led to discovering the bug. I'll add a comment to that effect, or else select some other dates.

@iSazonov iSazonov mentioned this pull request Jan 6, 2021
Closed
14 tasks
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@brianary
Copy link
Contributor Author

brianary commented Jan 15, 2021

Let me know if there's anything further I can provide.

@iSazonov iSazonov added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jan 15, 2021
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 15, 2021

@brianary Since it is a breaking change I ask PowerShell Committee to approve.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 15, 2021
@SteveL-MSFT SteveL-MSFT added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jan 20, 2021
@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Jan 20, 2021

@PowerShell/powershell-committee reviewed this, we agreed that this is a bug that should be fixed and this is likely a bucket 3 compatibility issue.

@brianary
Copy link
Contributor Author

brianary commented Jan 24, 2021 •
edited
Loading

@SteveL-MSFT should #14555 also be taken with this one, since they are so tightly related?

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 25, 2021

@brianary Please create new issue in PowerShell-Doc repository and add a reference to the issue in the PR description.

@brianary brianary mentioned this pull request Jan 26, 2021
Closed
@ghost
Copy link

ghost commented Feb 2, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost added the Review - Needed The PR is being reviewed label Feb 2, 2021
rjmholt
rjmholt approved these changes Feb 2, 2021
View reviewed changes
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 3, 2021

@brianary Please rebase. I hope after that CI-Windows will pass.

@ghost ghost removed the Review - Needed The PR is being reviewed label Feb 3, 2021
@brianary @rjmholt @BrianL-STCU
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Get…
c7df635 
…DateCommand.cs

Co-authored-by: Robert Holt <rjmholt@gmail.com>
@iSazonov iSazonov removed the Documentation Needed in this repo Documentation is needed in this repo label Feb 4, 2021
@iSazonov iSazonov merged commit 61fea6c into PowerShell:master Feb 4, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Feb 4, 2021
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 4, 2021

@brianary Thanks for your contribution!

@ghost
Copy link

ghost commented Feb 12, 2021

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

5 participants

@brianary @iSazonov @SteveL-MSFT @rjmholt @BrianL-STCU